Add support for filecrushing on Elastic MapReduce#2
Open
alexanderdean wants to merge 4 commits intoedwardcapriolo:masterfrom
snowplow:master
Open
Add support for filecrushing on Elastic MapReduce#2alexanderdean wants to merge 4 commits intoedwardcapriolo:masterfrom snowplow:master
alexanderdean wants to merge 4 commits intoedwardcapriolo:masterfrom
snowplow:master
Conversation
Owner
|
It all looks good so far. Just let me know when you want me to merge. |
Author
|
We ended up not using this library in the end. :-) You can merge as-is if you like, or close. I'll delete our fork in a few days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work-in-progress PR - do not pull yet
Hi @edwardcapriolo - this is an open pull request to add support for using filecrush on EMR.
There are three main things to fix:
FileSystemtmpDir- I think we should be referencing "${hadoop.tmp.dir}" rather than rawnew Path("tmp/crush-" + UUID.randomUUID());fs.makeQualified(dir).toUri().getPath()pattern with something that doesn't strip important S3 bucket informationLicense is missing #1 is done, see PR. Add support for filecrushing on Elastic MapReduce #2 is doable. V2 creates job with only one reduce #3 is a bit harder - I am working through this for EMR, but might need some help from you to make sure my changes don't break filecrush on standard HDFS.
Hoping this is the start of a collaboration! We're really excited about filecrush here at Snowplow.